Feat/non user namespace #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orphic user references without breaking previous versions
ledermann
approved these changes
Oct 29, 2019
|
Thanks! Before I work on the readme, can I check if this should be a new major or minor version? |
|
I think this PR should be released as 0.5.0 (minor update). |
|
Hi @ledermann, would you be releasing this version anytime soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have a use case where I have multiple users (admin_users and project_managers) so I cannot save the drafts under the user namespace. This PR will allow developers to save draft with a non user model.
The gist of this pull request:
user_typecolumn of string data type will be added to the drafts table whileuser_idis still preserved to prevent breaking previous versionsuser_typecolumnUSAGE
Developers on current version can just run the migration commands again to generate the second migration file.
TODO
if all is good, will add the migration guide to readme